Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy file to fix symlink #3759

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

mistercrunch
Copy link
Member

In assets/static we have a symlink pointing to docs/_build/html
which is .gitignored and missing in the repo since we don't want the
html-generated docs in the repo, meaning the symlink is broken

Having the symlink broken creates issues with pip-compile somehow.

Adding a dummy file here addresses that

In `assets/static` we have a symlink pointing to `docs/_build/html`
which is .gitignored and missing in the repo since we don't want the
html-generated docs in the repo, meaning the symlink is broken

Having the symlink broken creates issues with pip-compile somehow.

Adding a dummy file here addresses that
@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage remained the same at 71.271% when pulling 1f2d66b on mistercrunch:symlink2 into 5c03167 on apache:master.

@graceguo-supercat
Copy link

LGTM

@graceguo-supercat graceguo-supercat merged commit cccc473 into apache:master Nov 2, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
In `assets/static` we have a symlink pointing to `docs/_build/html`
which is .gitignored and missing in the repo since we don't want the
html-generated docs in the repo, meaning the symlink is broken

Having the symlink broken creates issues with pip-compile somehow.

Adding a dummy file here addresses that
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
In `assets/static` we have a symlink pointing to `docs/_build/html`
which is .gitignored and missing in the repo since we don't want the
html-generated docs in the repo, meaning the symlink is broken

Having the symlink broken creates issues with pip-compile somehow.

Adding a dummy file here addresses that
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants